Before I forget, would you please update the testsuite to have both a positive and negative case for this bug. I would imagine that it should be a pretty small change.
Thanks, -j On Tue, Aug 05, 2008 at 01:14:41PM -0700, [EMAIL PROTECTED] wrote: > Tom, > Sorry for my confusion. I didn't realize the other case also didn't > generate an error. That should probably be a separate bug. > > The change to the code looks fine to me. > > -j > > On Tue, Aug 05, 2008 at 02:16:09PM -0500, Tom Mueller wrote: > > The existing code silently ignores: > > > > pkg install [EMAIL PROTECTED] [EMAIL PROTECTED] > > > > I'm making the new code do the same thing for: > > > > pkg install [EMAIL PROTECTED] [EMAIL PROTECTED] > > > > Are you saying that the existing code is incorrect for the first case? > > Maybe that should be a different bug? > > > > Tom > > > > [EMAIL PROTECTED] wrote: > >> Tom, > >> Wouldn't it make sense to return an error in this case, instead of > >> silently ignoring one of the packages the user requested for installation? > >> > >> Thanks, > >> > >> -j > >> > >> On Tue, Aug 05, 2008 at 01:34:16PM -0500, Tom Mueller (pkg-discuss) wrote: > >> > >>> Please review this small change for issue 2795: > >>> > >>> Webrev: http://cr.opensolaris.org/~tmueller/cr-2795/ > >>> Issue: http://defect.opensolaris.org/bz/show_bug.cgi?id=2795 > >>> > >>> The fix checks to make sure that a successor to the FMRI being proposed > >>> isn't already in the target_fmri list for the imageplan. > >>> > >>> Thanks. > >>> Tom > >>> > >>> _______________________________________________ > >>> pkg-discuss mailing list > >>> [email protected] > >>> http://mail.opensolaris.org/mailman/listinfo/pkg-discuss > >>> > > > > > begin:vcard > > fn:Tom Mueller > > n:Mueller;Tom > > org:Sun Microsystems, Inc.;Update Center Software > > adr:;;21915 Hillandale Dr;Elkhorn;NE;68022;USA > > email;internet:[EMAIL PROTECTED] > > title:Senior Staff Engineer > > tel;work:877-250-4011 > > tel;fax:877-250-4011 > > tel;home:402-916-9943 > > x-mozilla-html:TRUE > > version:2.1 > > end:vcard > > > > > _______________________________________________ > > pkg-discuss mailing list > > [email protected] > > http://mail.opensolaris.org/mailman/listinfo/pkg-discuss > _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
