On Tue, Aug 05, 2008 at 05:25:53PM -0700, Brock Pytlik wrote:
> http://cr.opensolaris.org/~bpytlik/ips-2797/
Looks fine to me. My two code suggestions:
- move the degraded search into a separate function
- see if you can use the contents of /var/state/installed to speed the
directory walk. There's some new code that might help. You could do
indices = [
self.get_manifest_path(f)
for f in self.gen_installed_pkgs()
]
Or better yet, just use get_fmri_manifest_pairs(), and then you don't
have to call (or have) idx_to_fmri.
Suggested message text:
Search capabilities and performance are degraded.
To improve, run 'pkg rebuild-index'.
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
