On Thu, Aug 14, 2008 at 03:41:49PM -0500, Tom Mueller (pkg-discuss) wrote: > Webrev: http://cr.opensolaris.org/~tmueller/cr-2542/
Not that this matters for my platform of choice, but it seems like we're calling platform.system().lower() and platform.release().lower() a heck of a lot, rather than calling each one once and reusing the value. Might be nice to clean that up a bit. Otherwise, my only comment is: "win" and not "windows"? I've also found that, at least on Solaris, Python execs uname to retrieve this data. Ick. Not your problem here, but I think we might want to file a bug to fix that. Danek _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
