LGTM

I'll be taking a system up to 95 to make sure everything works and 
trying out the new bits, but I don't see anything wrong in the code.

Brock

jmr wrote:
> Folks here's a webrev for a potential stopper in the IPS GUI. Changes 
> brought in with changeset 429 and 456 in imageplan.py preexecute() and 
> execute() to check for and update indexes needed to be brought into the 
> IPS GUI equivalent code in installupdates.py under download_stage() and 
> installation_stage().
>
> Michal has spun the webrev. We have tested it and after installing a 
> package you can now search for files it contains without any problems.
>
> http://cr.opensolaris.org/~migi/2889_14_aug
>
> (note: there are a few 14 Aug revs up there, the above is the one to use)
>
> Issue:
> In copying over the code there is a line that deletes the pkg_plans, but 
> we need to use them to update the package list later on in 
> update_package_list() so we just did a local copy. This may not be 
> required and perhaps we could have just deleted the pkg_plans in the 
> update_package_list() function, but we wanted to be conservative.
>
>       408 +                self.update_list = self.ip.pkg_plans[:]
>       409 +                del self.ip.pkg_plans
>
> The change to act_output() was required to get the progress to function 
> correctly, as were the deletions of self.ip.progtrack.actions_done() and 
> move to the end of installation_stage().
>
> JR & Michal
>
> _______________________________________________
> pkg-discuss mailing list
> [email protected]
> http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
>   

_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to