Danek Duvall wrote: > On Thu, Aug 21, 2008 at 06:36:22PM -0500, Shawn Walker wrote: > >> Shawn Walker wrote: >>> Greetings, >>> >>> The following webrev contains fixes for the following issues: >>> >>> 1730 package containing space in name handled incorrectly >>> >>> Webrev: >>> http://cr.opensolaris.org/~swalker/pkg-1730/ >> Updated webrev: >> http://cr.opensolaris.org/~swalker/pkg-1730-2/ > > The changes look fine, but ... > > - I'd like to see the 1730 changes in their own changeset. Having the > two test fixes bundled in is just confusing.
The fixes go with the changes because with them, my new tests cause the test suite to misbehave. > > - I'm not sure why the fix to depot controller is necessary. Can this > represent a bug? Without that change, I could never get a make test-generate to succeed. -- Shawn Walker _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
