Shawn Walker wrote: > Michal Pryc wrote: >> Hello, >> New webrev available at: >> http://cr.opensolaris.org/~migi/04_09_2008_sync_with_ips_bug_3193_v2/ >> >> Comparing to the previous webrev, this changed the way of handling some >> widgets (some of them didn't have gobject.idle_add and should have, so >> now all that need this - the ones that are inside Thread contains this) >> >> Also when the user clicks cancel during install/update evaluate stage >> the CancelException is raised and handled properly. Before the function >> just returned which caused that the user couldn't quit properly application. > > Your code changes look fine, but I'm still testing. This 2nd version > resolved a segmentation fault that was present with the 1st version of > the patch.
Shawn, Most of the seg faults in the pygtk are because the gtk functions were called from another Thread without gobject.idle_add. I have reviewed all widgets in the remove.py and installupdate.py and made proper changes prior to the 1st version as John pointed in his review. Please let me know when you will decide "go/no go" for those changes :) best Michal _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
