Brad Hall wrote: > On Fri, Aug 29, 2008 at 08:49:01AM -0700, Erik LaFever wrote: > >> I suppose the correct link would help. >> >> http://cr.opensolaris.org/~elafever/test_suite_changes_3125/ >> >> Thanks, >> >> -Erik >> >> Erik Lafever wrote: >> >>> webrev for test-suite additions and changes: >>> http://cr.opensolaris.org/~elafever/test_suite_additions_3125 >>> >>> I have been working with the cli tests in the pkg gate and have added >>> several test groups to reflect the different subcommands of pkg. I went >>> through the existing tests and moved them into the correct groups and >>> added some more tests along the way. The addition of these tests and >>> changes has increased the time for the CLI tests to complete from 108 >>> tests in 451 seconds to 152 tests in 547 seconds. There are two tests >>> that currently Error and they are related to cr1331 where pkg install >>> fails when a package is known but the repo is offline. >>> >>> I have added tests under the following names and moved existing tests >>> into the appropriate areas: >>> >>> t_pkg_install.py >>> t_pkg_uninstall.py >>> >>> t_pkg_authority.py >>> t_pkg_set_authority.py >>> t_pkg_unset_authority.py >>> >>> t_pkg_image_create.py >>> t_pkg_image_update.py >>> >>> t_pkg_info.py >>> t_pkg_contents.py >>> >>> t_pkg_list.py >>> t_pkg_search.py >>> >>> t_pkg_refresh.py >>> t_pkg_verify.py >>> t_pkg_version.py >>> t_pkg_help.py >>> >>> Below breaks down some of the changes and additions: >>> >>> t_pkg_install.py >>> this combines tests from: >>> t_pkg_install_basics.py >>> t_pkg_install_corrupt_image.py >>> t_upgrade.py >>> t_commandline.py (just the pkg install parts) >>> >>> t_pkg_uninstall.py >>> includes tests from: >>> t_commandline.py >>> >>> t_pkg_authority.py >>> t_pkg_set_authority.py >>> t_pkg_unset_authority.py >>> includes new tests and some tests from: >>> t_commandline.py >>> >>> t_pkg_image_create.py >>> includes new tests and tests from: >>> t_commandline.py >>> t_image_create.py >>> >>> t_pkg_image_update.py >>> includes new tests and tests from >>> t_commandline.py >>> t_upgrade >>> >>> t_pkg_info.py >>> t_pkg_contents.py >>> I put info and contents into their own groups >>> added tests from t_info_contents.py >>> added new tests >>> pulled some tests from t_commandline.py >>> >>> >>> t_pkg_list.py >>> renamed t_list.py to t_pkg_list.py >>> added tests from: >>> t_commandline.py >>> t_list.py >>> added some new tests >>> >>> t_pkg_search.py >>> renamed t_search.py to t_pkg_search.py >>> added tests from >>> t_commandline.py >>> t_search.py >>> t_search_multi.py >>> added some cli tests >>> >>> >>> t_pkg_refresh.py >>> t_pkg_verify.py >>> t_pkg_version.py >>> t_pkg_help.py >>> created these groups and added some cli tests to >>> begin with. >>> > > Hey Erik, > > So the new tests look good, though I'm slightly worried about all the moving > around. The organization does make sense from the standpoint of everything > related to a "pkg <x>" command is in a pkg_x file, but I just want to make > sure that any organizational changes made are flexible enough that we end up > not having to reorganize again :) Moving stuff around always make for merge > headaches -- but in this case (unless anyone has any huge outstanding test > suite changes), I don't think it'll be too bad. > > So, just to make sure: are others OK with the organizational changes of the > cli directory? > > Anyhow, thanks for getting these in.. sorry it took so long to get back to you > on the review. > > -Brad > _______________________________________________ > pkg-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/pkg-discuss > Thanks Brad,
I did not see any replies to your question here? What do we need to do to get this moving? The webrev has been updated and is based on current gate bits. To speed things along, this change request does not have any new tests, it is just for the restructuring of the cli tests into the correct categories. Once this change gets put back I can start adding the new test cases to the different categories. These changes seem flexible enough to me and I do not have any intentions for more major changes to the test suite structure. Here is the updated webrev: http://cr.opensolaris.org/~elafever/3125_test_suite_changes/ Thanks, -Erik _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
