> Installer: > http://cr.opensolaris.org/~dminer/dc-681-v2/
I assume this webrev is actually http://cr.opensolaris.org/~dminer/slim-681-v2/, right? Looks good. > Distro Constructor: > http://cr.opensolaris.org/~dminer/dc-681-v2/ src/build_dist.lib Line 457 - It would be nice if the LiveCD's contents could be "pkg verify -f" clean or as close as possible. Do we know whether the resulting permissions of (the modified) ${MICROROOT}/etc/X11/gdm/custom.conf are the same as what the package says they should be? Line 465 - Same question here for ${MICROROOT}/etc/user_attr. Line 656 - Same question here for $PROTO/boot/grub/menu.lst. > Pkg (first is the reduced true changes, second is the full webrev): > http://cr.opensolaris.org/~dminer/pgate-681-v2/ > http://cr.opensolaris.org/~dminer/pgate-681-full-v2/ src/util/distro-import/98/Makefile Lines 71, 89, 100, 171-174 and 186-193 - In the past, we've tried to allow importing earlier builds by leaving the creation of the customized files in the proto area while instead adjusting the various import files (SUNWfixes.prototype could also have been adjusted although it seems I've been remiss in cleaning that up at the same time). However, removing these lines will prevent us from rebuilding earlier builds (something that's difficult to do in a consistent way, admittedly). As such, I'd recommend leaving these lines as-is for now - the unneeded and unused custom versions of these files will be built in the proto area but they won't be imported into the base packages. Other than these issues, the webrevs look great. Thanks for addressing the issues. dsc _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
