Looks good, thanks. -j
On Wed, Sep 17, 2008 at 01:33:05PM -0700, Brad Hall wrote: > On Wed, Sep 17, 2008 at 01:25:11PM -0700, [EMAIL PROTECTED] wrote: > > Hi Brad, > > > > I would write this as, "Link to webrev." CR is an overloaded term, and > > many people use this to mean "Change Request." A change request is > > synonymous with a bug in Bugster. > > Ok, easy enough. > > > > Link to CR: http://cr.opensolaris.org/~bhall/bug-850/ > > > > Comments follow: > > > > publish/transaction.py: > > > > - lines 64 & 66: I know that in this case the success code we're > > expecting is a 100 or 200 response; however, I still think it's a > > bit misleading to have 0 be an error. Could we use something like > > -1 in this case? > > > > publish.py: > > > > - line 77: Same concern as above. Generally, 0 is a success code. > > > > Thanks, > > > > -j > > Changed to -1, webrev updated in place. > > Thanks, > Brad > _______________________________________________ > pkg-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/pkg-discuss _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
