On Thu 18 Sep 2008 at 06:09PM, [EMAIL PROTECTED] wrote:
> Looks good.  Thanks for fixing this.
> 
> -j
> 
> On Thu, Sep 18, 2008 at 05:14:46PM -0700, Brad Hall wrote:
> > Hi,
> > 
> > Link to webrev: http://cr.opensolaris.org/~bhall/bug-3432/
> > Link to bug: http://defect.opensolaris.org/bz/show_bug.cgi?id=3432
> > 
> > Since the cli/testutils exceptions weren't inheriting from pkg5testsuite (or
> > unittest.failureException) the suite treated them as errors when they 
> > actually
> > should have been treated as failures.

Thanks for cleaning this up!  Looks good to me.

> > The other part to this bug is the supression of results which are expected 
> > by
> > the baseline (even if it's a failure); but we can file another bug for that 
> > if
> > we decide that is reasonable to do.

A command line option for that would be nice, but we definitely need to
be able to see the raw what-is-failing-and-why view of things.

        -dp

-- 
Daniel Price - Solaris Kernel Engineering - [EMAIL PROTECTED] - blogs.sun.com/dp
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to