Shawn Walker wrote: > Brock Pytlik wrote: >> Webrev: >> http://cr.opensolaris.org/~bpytlik/ips-3618-v1/src/packagemanager.py.wdiff.html >> >> >> >> Bug: >> Manifest retrieval error needs more info and to not show a traceback >> http://defect.opensolaris.org/bz/show_bug.cgi?id=3618 >> >> While I'd like to fix the source of the underlying bug (1133), I feel >> like we have little way of telling what the actual problem. Since the >> problem is hard to reproduce, I'm suggesting we try this approach to >> allow us to gather more information when problems are encountered. It >> also removes the traceback from what the user is shown. > > I think you meant: > http://cr.opensolaris.org/~bpytlik/ips-3618-v1/ > > client.py: > lines 2189, 2190: wording suggestion: "An error was encountered > while attempting to retrieve package or file data for the requested > operation." > > retrieve.py: > lines 35,42: s/Retrival/Retrieval/ fixing this here means changing > it everywhere else, of course > > lines 36, 42: docstrings are appreciated > > Otherwise, looks fine. > > installupdate.py: > line 364: I know this isn't your fault, but can you: > s/Attemping/Attempting/ > > Cheers, New webrev reflecting shawn's comments at: http://cr.opensolaris.org/~bpytlik/ips-3618-v2/
All changes suggested were made. Brock _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
