image.py Line 1538, 1990: I don't see why you're changing this function to take progtrack, and then not using it.
1928-1932: I don't really understand why having a user specified cache_dir means that we shouldn't clean it up on completion. Also, am I correct that, before, we were adjusting the goal down, now, we adjust the downloaded bytes up, when the file is cached on disk? Could this lead us to provide some truly strange/amazing/weird results for the bytes/sec measure? I'm not saying counting down is necessarily the right behavior (though I do kind of like it) but giving what I think is incorrect data seems worse. If you provided a way (or filed a bug to provide a way) for those bits which are already on disk to not be counted in the bytes/sec measure, I don't think I'd have an objection. As a side note, thanks for making __set_dirs, it's a better solution than what I'd thought of for bug 1651. Thanks, Brock Dan Price wrote: > Hi, > > Please review the following fixes: > > 3508 zone install should utilize/populate global zone d/l cache > 2279 client output oddities since caching changes > > http://cr.opensolaris.org/~dp/pkg-dldir/ > > This passes the test suite and I've checked the GUI as well. > > I'm purposely not documenting PKG_CACHE at this time-- I'd like > to gain some experience with it before we do so. > > The reason for the perms changes in this wad is so that 'make link' > works again (the various brand-hook scripts need to be executable). > > -dp > > _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
