Hi Brock,
Another e-mail :)
in the api.py there is variable img, which should be self.img:
def __licenses(self, mfst, local):
"""Private function. Returns the license info from the
manifest mfst. Local controls whether the information is
retrieved locally."""
license_lst = []
for license in mfst.gen_actions_by_type("license"):
if not local:
s = misc.FilelikeString()
hash_val = misc.gunzip_from_stream(
license.get_remote_opener(img,
mfst.fmri)(),
s)
text = s.buf
else:
text = license.get_local_opener(img,
mfst.fmri)().read()[:-1]
license_lst.append(LicenseInfo(text))
return license_lst
best
Michal
Michal Pryc wrote:
> Hi Brock,
> I have made some changes to the packagemanager to consume new API it
> looks much simpler now (the date should be 30_09_2008):
>
> http://cr.opensolaris.org/~migi/29_09_2008_packagemanager_api_first_cut/
>
> The biggest changes are in the installupdate.py, which is now used for
> all operations install/update/remove, that is why we could delete
> remove.py.
>
> This webrev is nothing more then just an idea where we are in the
> implementation, so please don't spend much time on it as this will be
> changed Tomorrow a little bit to add exception handling and cancelling.
> It consists of all previous webrevs which I've send and were not
> reviewed yet and your api. I prefer to do that, otherwise it will be
> very difficult for me to merge all the changes later on.
> Basically it uses an api calls in all places where they could be used,
> in other places we are accessing the old way pkg.client* pkg.misc.
>
> What is done:
> - removed files as not needed anymore (gui.remove.py, gui.thread.py,
> gui.filelist.py)
> - All operations for install/update/remove are throught the new API
> - some of the operations for packagemanager.py (refresh catalogs) are
> done through the api.
>
>
> What needs to be done:
> - During removal all the dialog names should be changed (0.5h of work)
> - Update all operation (this requires checking if the SUNWipkg-gui is in
> place and I am waiting for your comment what is the best of doing that)
> (2h of work)
> - cancelling from different stages. This requires fixing dead-lock bug,
> which I've described in my previous e-mail. (shoud be straight forward
> once the dead-lock will be fixed)
> - Better exception handling, currently it does nothing but raise. For
> gui we should have appropriate information. (2h of work)
>
>
> best
> Michal
>
>
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
