On Wed 01 Oct 2008 at 05:19PM, Shawn Walker wrote:
> Greetings,
>
> The following webrev contains fixes for these bugs:
> 3569 pkg state code obviates use of _get_version_installed
>
> http://cr.opensolaris.org/~swalker/pkg-3569/
>
> Change Summary:
> * Changes methods that relied on _get_version_installed (that check
> storage directly) to use the new get_version_installed method that uses
> pkg_states instead to determine the version installed of a particular
> package.
>
> * Simplifies gui code that was used to retrieve this information.
>
> The gui seems a little faster on startup, but it's difficult to get
> reliable timings.
I presume the CLI is about the same speed on the core ops like
'pkg list', 'pkg install -nv' and 'pkg image-update -nv'?
In the GUI, it sure seems like get_installed_version could completely
go away (since it is now a one liner), but I think fixing that
is optional.
I don't understand what line 1706 means. Is that part of another
bug fix?
Just as I was finishing looking at this, the review disappeared from
cr.opensolaris.org...
-dp
--
Daniel Price - Solaris Kernel Engineering - [EMAIL PROTECTED] - blogs.sun.com/dp
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
