On Sun, Oct 05, 2008 at 06:28:22PM -0500, Shawn Walker wrote:
> http://cr.opensolaris.org/~swalker/pkg-3715-2/
Wow, that's a bit more code. :)
client.py:
- line 1934: You've stopped testing __img; does that mean you're
confident it won't be None here? It seems like it, but it's a change,
so I'm just making sure.
- line 1965, et al: You don't need to str() the exceptions here; that's
done for you in error().
- line 1990: space after \n.
history.py:
- line 393: we haven't been strict about this, but we should think about
being more careful about not accidentally capturing KeyboardInterrupt.
- line 401, 405: wouldn't these be better as assert()s? These tests are
checking for other code being broken, not a normal error condition, as
far as I can tell.
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
