Brock Pytlik wrote: > http://cr.opensolaris.org/~bpytlik/ips-1929-v3/ > > Resynced to gate and updated per Danek's comments. Looking for one more > reviewer before I put back.
client.py: line 180: maybe all_versions would be a better variable name than collapse? line 229: s/[hv]=/[hv] =/ line 233: Some comments explaining the sorting and what affect each statement has might be nice. Such as, "fmris with the preferred authority are returned first", etc. Some newlines before and after this nested function might also be helpful for readability. line 245: Are you sure you don't want get_authority() instead of get_authority_str()? I ask because the comment for get_authority_str() indicates that it's really only for code that writes out manifests to disk. pkg.1.txt: line 223: s/FMRIS. With/FMRIs. With/ Otherwise, looks fine. Cheers, -- Shawn Walker _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
