Thanks.  Fixed.
Tom

Brock Pytlik wrote:
t_depend:
line 68, 92: Please remove the space before check, and probably capitalize it

Other than that, looks good to me.

Brock

Tom Mueller (pkg-discuss) wrote:
Links to issues:
http://defect.opensolaris.org/bz/show_bug.cgi?id=3737
http://defect.opensolaris.org/bz/show_bug.cgi?id=3767

Link to webrev:
http://cr.opensolaris.org/~tmueller/cr-3737/

This changeset adds some unit test cases for optional dependencies so that the mistake I made would be caught in the future by the unit testing. The problem in 3737 in imageplan.py was already fixed by an earlier checkin. This changeset does fix the problem in installupdate.py.

For 3767, there is a difference in behavior between Solaris 10 and Opensolaris for /bin/sh -c ";ls". So the code was changed to avoid the empty command at the beginning of the command list.

Thanks.
Tom


_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss


begin:vcard
fn:Tom Mueller
n:Mueller;Tom
org:Sun Microsystems, Inc.;Update Center Software
adr:;;21915 Hillandale Dr;Elkhorn;NE;68022;USA
email;internet:[EMAIL PROTECTED]
title:Senior Staff Engineer
tel;work:877-250-4011
tel;fax:877-250-4011
tel;home:402-916-9943
x-mozilla-html:TRUE
version:2.1
end:vcard

_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to