Clean merge against the gate for UpdateManager with Michals packagemanager changes in.
http://cr.opensolaris.org/~jmr/updatemanager_v11_Oct09/ JR jmr wrote: > Thanks for the review - much appreciated, given everyone's scramble to > get into 2008.11 code freeze :) > > There are some areas that we could reuse, but as you say the error > handling is quite different and we are presenting the progress in a > different way, the UM in a more compact fashion and the PM with multiple > dialogs. Something to review after we get this landed. > > I've made a few additions to the Update All so we now can handle a disc > quota exception and allow the user to launch the BE Management dialog > from PM to get more space if need be. I also added some flags to allow > us to turn on off Update All/ Install Updates, depending on how xDesign > want us to present UM to the user for 2008.11 release. The default is to > just show Update All and that is probably what we will ship with. > > http://cr.opensolaris.org/~jmr/updatemanager_v9_Oct08/ > > Hope to land this in the gate tomorrow, will get Michal to review the > latest bits I've added. Michal is posting a webrev for addtional cancel > support and the UM will just pick this up when its there. > > JR > > Brock Pytlik wrote: > >> jmr wrote: >> >>> Brock - here is the latest webrev, working against your new v8 api in >>> the gate and Michals latest changes. I have incuded your suggestion >>> and added an Update Image, tested it and its working well :) >>> Its a bit painful testing the image update, any hints as to how I >>> could speed things up - I normally use beadm create before-update and >>> then rollback to that after the image-update so I lose any download >>> cache that is there. >>> >>> Will also need to add new icons when I get them. >>> >>> http://cr.opensolaris.org/~jmr/updatemanager_v5_Oct07/ >>> >>> >> General comments: >> It might make sense for packagemanager and updatemanager to share some >> functions/modules. For example, __update_image in updatemanager.py >> (lines 895-955) and installupdate.py (lines 296-310) seem like they >> should be very similar, though the exception handling might differ a >> bit, but have some substantial differences in their code paths and >> error checking. >> >> Other than that, everything seems to be fine from an API perspective. >> >> Brock >> >> >>> JR >>> >>> jmr wrote: >>> >>> >> [snip] >> > > _______________________________________________ > pkg-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/pkg-discuss > _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
