General comments: Could --content-root be changed to be --web-content-root, or something else more specific about what's actually stored in that directory?
Config.py: Line 90: Perhaps raise something other than a RuntimeError here? Other than that, LGTM. Brock Shawn Walker wrote: > Greetings, > > The following webrev contains fixes for the following issues: > 242 desire ability to set content root > 3815 depot manpage doesn't explain --mirror option > > webrev: > http://cr.opensolaris.org/~swalker/pkg-242-3815/ > > Change Summary > ============== > * Clarified mirroring usage and manpage documentation for depot > > * Alphabetised command-line options for depot in documentation, etc. > > * Added new --content-root parameter to allow control over where the > static content used by the depot's browser user interface (feed icons, > logos, etc.) is located. > > * Added new pkg/content_root SMF property and updated manifest. > > * Added web_static_root SvrConfig attribute in preparation for > depot-refacing work (trying to split out the work into small changesets). > > * Added missing --mirror documentation to pkg.depotd manpage. > > * Ensured --mirror mode wasn't confused with --content-root options by > clarifying wording. > > Cheers, > _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
