It looks okay to me; however, I found it odd that you'd solicit code review and then integrate without it.
-j On Mon, Oct 13, 2008 at 06:57:42PM +0100, jmr wrote: > J - I've taken the patch and applied it to a clean snap of the gate, > built it and installed it and the permissions on: > /usr/share/icons > /usr/share/applications > > Are both: owner=root group=other > > Which would appear to address David's issue. Any comments? Can I commit > this or do you want me to hold off? > > JR > > > [EMAIL PROTECTED] wrote: > > Has anyone reviewed this fix? > > > > -j > > > > On Mon, Oct 13, 2008 at 06:43:59PM +0100, jmr wrote: > > > >> Hi - I will commit Michal's webrev below (he's only intermittent > >> internet access today). > >> > >> JR > >> > >> > >> > >> John, > >> With this patch the group for icons and everything what is inside icons > >> changed the ownership to group "other" so it looks like it's fine. > >> The small change is required because the usr/share changed the group > >> from sys to other. I have made new webrev. > >> Could you submit mine, since I will be offline? > >> > >> > >> http://cr.opensolaris.org/~migi/13_10_2008_um_3879_v1/ > >> > >> best > >> Michal > >> > >> jmr wrote: > >> > >>> Hi - this is an attribute issue pointed out by David: > >>> > >>> http://cr.opensolaris.org/~jmr/um_3879_v1_Oct13/ > >>> > >>> Owner for usr/share/icons was being set to bin as opposed to other. > >>> > >>> JR > >>> _______________________________________________ > >>> pkg-discuss mailing list > >>> [email protected] > >>> http://mail.opensolaris.org/mailman/listinfo/pkg-discuss > >>> > >>> > >> _______________________________________________ > >> pkg-discuss mailing list > >> [email protected] > >> http://mail.opensolaris.org/mailman/listinfo/pkg-discuss > >> > > _______________________________________________ > pkg-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/pkg-discuss _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
