> I've updated this webrev:
>
> http://cr.opensolaris.org/~dduvall/pkg-devlinks-2/
Looks good - I just have a few comments:
Various driver import files
Now that Rich has fixed the continuation line issue, I've begun
cleaning up import files as I update them. If you could do the
same here, even better. :-)
I noticed the parser is a little bit particular (need to file a
bug on that) so I've been using the convention
add driver name=blah ..... privs=sys_config<space><blackslash>
<tab>devlink="blah......"
src/util/distro-import/100/common/SUNWcsd
Although etc/devlink.tab is no longer pulled from SUNWfixes,
you still have the chattr here which seems strange. What
package ends up owning the file then?
Would it make more sense to continue delivering a skeletal
etc/devlink.tab (see attached) in SUNWcsd via SUNWfixes so the
driver action will append to that?
src/util/distro-import/Makefile
There have been a few other cases were the cleanup of SUNWfixes
caused earlier build imports to fail (see 3694, for example).
Should this section actually be based on CACHED_FILES (which
includes ELIDED_FILES) rather than just ELIDED_FILES?
dsc
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
