Looks good. One modification I would suggest: expand the IOError catch blocks around the os.<xxx>() operations to include OSError. IIRC, the os module will sometimes raise them instead of IOErrors.
I didn't realize that os.stat returned an object. I had been using the antiquated method of using stat.py's constants as an index into a tuple. I may have to go back and fix this in my code, to avoid confusion. -j On Tue, Oct 14, 2008 at 11:25:08AM -0700, Danek Duvall wrote: > http://cr.opensolaris.org/~dduvall/pkg-devlinks-perms/ > > should fix > > 3903 driver action doesn't reset etc/devlink.tab owner/group to match > SUNWcsd > > where I was writing devlinks data into a temp file and moving that into > place, but without changing the perms on the temp file away from 0600 and > whatever the current uid/gid were. > > Thanks, > Danek > _______________________________________________ > pkg-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/pkg-discuss _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
