updatemanager.py Line 1129: Please don't just bump the version without making sure the code works with the bumped version. The reason we have API versioning is so that we fail early if the API is changed incompatibly rather than waiting till we happen to travel down the changed code path. In this case, plan_install now returns a tuple, not a boolean. As far as I can tell, this line hasn't been updated to accept the new return value.
I'm also unclear as to the purpose of __get_api_obj. If the api object isn't created on first trial, why would it succeed after that? I'll give more feedback in a bit when I get back from a meeting. Brock jmr wrote: > Hi, > > Simple patch: > http://cr.opensolaris.org/~jmr/um_3981__3998_3950_v2_Oct16 > > Bumping API version to 1. UM currently failing in the gate as the > underlying API has bumped the version and the call to: > > api.ImageInterface(...CLIENT_API_VERSION...) with version 0 > > Throws a version mismatch exception. Also changed how this error was > reported in the Details pane. > http://defect.opensolaris.org/bz/show_bug.cgi?id=3998 > > Range of minor UI changes to conform to UI Spec. > http://defect.opensolaris.org/bz/show_bug.cgi?id=3981 > > Change Copyright file to short version: > http://defect.opensolaris.org/bz/show_bug.cgi?id=3950 > And removed SUNWipkg-um.import - David Comay told us it's no longer needed. > > Thanks, > > JR > _______________________________________________ > pkg-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/pkg-discuss > _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
