On the os.unlink, agreed. Especially since the failure is being ignored
anyway.
Tom
Danek Duvall wrote:
On Thu, Oct 16, 2008 at 08:11:23PM -0700, Brock Pytlik wrote:
http://cr.opensolaris.org/~bpytlik/ips-3365-v1/
catalog.py:
- line 84: I think you can actually use os.unlink() here, since
portable.remove() is for Windows, when the file is possibly in use,
which it shouldn't be here. I'd get Tom to clarify.
- line 85: "e" not used
t_pkg_depotd.py:
- line 129, 130, 135, 137: space after comma
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss