Makefile: 34: Wouldn't AN_FLAGS be something the user would be changing (and therefore perhaps mentioned in the readme? Do we want more documentation about what the options here are, or what their format is?
an2_ip.py: 33-38: Are these example lines, or should they be removed? If they're staying, a comment to explain would be nice 43: If this is a user run script, it would be nice if some error was produced if a specified file couldn't be found. Even if it's not, some kind of warning error when a file is not found would probably be helpful for debugging an2_ip_active.py: 65: Don't quite follow why we do int(str(days)) 75: Will this always be a 30 day window? 142: commented line 126-140: I'm probably just not getting it, but I can't figure out what the purpose of these lines are Other than that, LGTM, Brock Brad Hall wrote: > Hi, > > In an effort to make the depot/apache log analsys scripts useful/available for > others running pkg depots, we need to put them into the pkg gate. > > Here is a link to the webrev: > http://cr.opensolaris.org/~bhall/log-scripts-gate/ > > One question I had: does it make sense to include a set of sanitized sample > logs for testing purposes? We can take real logs and just modify the IP > addresses. > > Thanks, > Brad > _______________________________________________ > pkg-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/pkg-discuss > _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
