Danek Duvall wrote: > On Wed, Oct 22, 2008 at 05:52:46PM -0700, Brock Pytlik wrote: > > >> http://cr.opensolaris.org/~bpytlik/ips-3799-v2/ >> > > api.py: > > - line 71: since you're updating this with some frequency, perhaps > set(xrange(CURRENT_API_VERSION)) would do the trick once and for all? > Well, except that there are incompatible versions (version 0) for example. What I think I'll do is add another variable EARLIEST_COMPATIBLE_VERSION next to CURRENT_API_VERSION. In this case, that will be set to 1, and I'll so set(xrange(EARLIEST_COMPATIBLE_VERSION, CURRENT_API_VERSION + 1).
Does that sound reasonable? I'll make the changes listed below. Sorry about the spaces, I've been trying to be better about catching those. Do you (or anyone else) want to see another webrev, or is this ready to go back? Brock > image.py: > > - line 1286, 1297, 1357, 2103: remove spaces > > progress.py: > > - line 482: this might be more readable as > > print " " * self.cat_curstrlen, > > - line 64, 109, 223, 489: remove spaces > > Danek > _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
