On Fri, Oct 24, 2008 at 02:56:23PM -0700, Brock Pytlik wrote: > Danek Duvall wrote: >> On Fri, Oct 24, 2008 at 02:39:28PM -0700, Brock Pytlik wrote: >> >> >>> http://cr.opensolaris.org/~bpytlik/ips-4229-v1/src/modules/client/progress.py.wdiff.html >>> >> >> I would have expected that refresh_output_done() would be called >> somewhere, >> instead, to do that? >> >> Danek >> > Fair question. There are two approaches progress takes in various places. > One, taken by the catalog fetching for example, calls start and done for > each fetch. The other, for example evaluate, has a single start and end > call, and updates the progress in the middle. When doing refresh_output, I > choose to follow the evaluate style. This means that start and done are > called one, and progress is called as each authority is processed. I chose > that method because it fits better with passing in the total number of > auths once.
Okay. Code looks fine. Thanks, Danek _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
