This looks good to me. Was some of the problem caused by things like PyDict_SetItem bumping the reference count of its arguments?
Thanks, Brock Danek Duvall wrote: > http://cr.opensolaris.org/~dduvall/pkg-memleak/ > > This is the fix for the memory leak caused my by rewrite of the action > parsing in C. It's pretty much all adding Py_DECREF() to a bunch of places > in _actions.c. > > It passes the testsuite, it passes actionbench, and it demonstrates no > increase in heap size when run through attachment 625 in bug 4116, which > repeatedly creates the same action, periodically emitting RSS. > > It's even a bit faster than it was previously. Actionbench shows a 17% > increase in speed in the "action creation" test, and a 6% increase in speed > in the "manifest contents loading" test. > > Note that while all success paths are accounted for, and all paths that go > raise a MalformedExceptionError are as well, there are some failure paths > that don't do any reference (ac)counting. I believe that these will only > happen in very rare cases -- such as out of memory, or corrupt memory -- > that are likely to cause the program to crash for other reasons, anyway. > All the normal cases should be fine. > > If anyone can review this today or Sunday, that'd be fantastic -- it might > just sneak into build 100. If not, then soon please, since 101 will follow > shortly. > > Thanks, > Danek > _______________________________________________ > pkg-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/pkg-discuss > _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
