On Sat, Oct 25, 2008 at 09:14:26PM -0700, Brock Pytlik wrote:

> http://cr.opensolaris.org/~bpytlik/ips-4239-v1/

set.py:

  - line 69: I think either skipping this action or falling back to one of
    the other if clauses would be better than raising an exception here.

  - I think rather than computing colon, I might do:

        try:
            scheme, cats = self.attrs["value"].split(":", 1)
            return {
                scheme: cats.split("/")
            }
        except ValueError:
            pass # (or return, etc)

    but I don't care too much.

Post November, we really need to fix the output of search when it comes to
set actions -- actually following the suggestion in the second comment of
Manifest:search_dict().  That would allow us to have the more natural
output of the search that Rich is asking for.

Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to