John Levon wrote: > Hi, can I get reviews for these changes: > > http://cr.opensolaris.org/~johnlev/osol-xvm-vnc/ >
It would be helpful to have something in the bug outlining the design of the fix, but I'm fairly sure this is incomplete, as the set of services enabled on the CD is governed by a profile (generic_live.xml) delivered in and applied by the distro constructor. It would seemingly be simpler to use a dependent clause in vnc-config.xml, which would avoid the need to modify gdm.xml and hence the new import file and that change to SUNWfixes. I don't believe you should be changing 100a/slim_cluster; 98/i386/SUNWxvmipa also shouldn't be changed, but instead copied into 101 and updated. Dave _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
