New webrev incorporating Shawn's changes: http://cr.opensolaris.org/~jmr/pm_4008_v3_Oct28
JR jmr wrote: > Thanks for the review Shawn much appreciated. Comments below: > > JR > > Shawn Walker wrote: > >> jmr wrote: >> >>> Hi , following on from Danek's memory leak fix in 4116 and Shawn's >>> manifest cache workaround in 4263, we have a number of optimizations >>> to make to the GUI, that will let us close out 4008 for the 2008.11 >>> release: >>> <http://cr.opensolaris.org/%7Emigi/21_10_2008_bug_4116_v3> >>> - Using a single api object >>> - Moving over to use the new actions support in api.info >>> - Various lazy loading approaches for manifest details and licenses. >>> >>> Also bumps the API version in PM and UM to 4. This is all GUI >>> specific code, Padraig can you take a look thanks. >>> >>> http://cr.opensolaris.org/~jmr/pm_4008_v2_Oct28/ >>> >> packagemanager.py: >> line 40: s/lenght/length/ >> > Done > >> lines 580, 988, 992, 993, 994: suggestion, s/Fetching/Retrieving/ >> > Our doc writer has final say on this stuff for us. > >> line 1042: Long-term an arbitrary character length isn't very >> multi-lingual friendly (i.e. MAX_DESC_LEN) and '...' is not universal >> among languages. Going to need something different here eventually. >> >> line 1112: What are tue users? - the users >> > #XXX revisit this and replace with gobject.timer_add() > instead of sleep > # sleep for a little time, this is done for the users > who are > # fast browsing the list of the packages. > > >> line 1142: You don't need a backslash for line-continuation when you >> are within parentheses. This is in several places. >> > This is done throughout the GUI code. We can remove it but as it > involves a lot of the code I would prefer to do so in a separate webrev > after the 2008.11 rev goes out. > >> updatemanager.py: >> line 56: This is wrong. It should be "updatemanager"; otherwise, >> the memory usage workaround we just put in won't work for updatemanager. >> >> > Thanks - nice catch :) > > _______________________________________________ > pkg-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/pkg-discuss > _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
