I think line 48 should be removed. Other than that, lgtm.
Brock Padraig O'Briain wrote: > jmr wrote: > >> Looks fine - have you tested the error condition? Moving the cron file >> out of the way for instance. >> > > Moving crontab file out of the way does not generate an error condition. > If root's crontab file, i.e. /var/spool/cron/crontabs, is not present > enabling the SMF service will cause the file to be created and our entry > to be added to it. > > Padraig > >> JR >> >> Padraig O'Briain wrote: >> >>> The fix for this bug is to add the functions which were omitted by >>> mistake. >>> See http://cr.opensolaris.org/~padraig/4253_v1_Oct29/ >>> >>> Padraig >>> _______________________________________________ >>> pkg-discuss mailing list >>> [email protected] >>> http://mail.opensolaris.org/mailman/listinfo/pkg-discuss >>> >>> > _______________________________________________ > pkg-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/pkg-discuss > _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
