Looks ok for me. Michal
jmr wrote: > Should be explicitly returning False, not relying on the default behavior: > > http://cr.opensolaris.org/~jmr/pm_4306_v2_Oct30/ips_gate.patch > > JR > > jmr wrote: >> Hi, here is a simple webrev to enhance the url and name checking in >> the PM GUI Manage Repositories code. It is now using the same url and >> name checks as the CLI set-authority. So when you are in the PM Manage >> Repositories dialog if you enter an invalid name by for instance >> adding a space the Add button becomes disabled on the fly, same is >> true if you have an invalid URL. The Add button is only enabled now >> when both a valid URL and Name are entered. >> >> This bug is a Stopper as adding an authority with an invalid name can >> really screw things up. >> http://defect.opensolaris.org/bz/show_bug.cgi?id=4306 >> >> JR >> >> http://cr.opensolaris.org/~jmr/pm_4306_v1_Oct30 >> >> >> >> _______________________________________________ >> pkg-discuss mailing list >> [email protected] >> http://mail.opensolaris.org/mailman/listinfo/pkg-discuss > _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
