Looks good to me. Have you tested all the error conditions explicitly ? Some comments below.
JR Michal Pryc wrote: > Hi, > Small fixes for few minor bugs, webrev: > > http://cr.opensolaris.org/~migi/30_10_2008_bugfixes_3203_3202_4018_1579_2121/ > > > Fixes: > [4018] > Package Manager - Window width bug > http://defect.opensolaris.org/bz/show_bug.cgi?id=4018 > Ok > [3202] > Add dialog for setting name for Boot Environment > http://defect.opensolaris.org/bz/show_bug.cgi?id=3202 Fine - mimics UM functionality now. > > [3203] > Add dialog for update error - Not enought free space > http://defect.opensolaris.org/bz/show_bug.cgi?id=3203 Nice catch adding this to UM for execute stage not just download. > > [1579] > Details text field should be anchored to bottom > http://defect.opensolaris.org/bz/show_bug.cgi?id=1579 Ok > > [2121] > Install/Upgrade Check dialog needs to be more informative > http://defect.opensolaris.org/bz/show_bug.cgi?id=2121 > > Ok also see you added install phase label updates which looks fine. > > best > Michal See a change in get_datetime() to handle invalid date formats and in __get_pkgstr_from_pkginfo() setting date string to "" if you fail to grab it. Under what circumstances can this happen? _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
