The code looks like what we discussed. I've diffed the binaries on your machine with the binaries I originally provided in my package and they match except for the previously identified rtcapihook.so and rtcboot.so. I verified that these files had the same ELF CHECKSUM as the same files in the previous release.
Hopefully the fact that they have different .comment sections won't confuse anyone. :-/ So it looks good to me. --chris Rich Burridge wrote: > Hi all, > > (I realize there is a hold on checking anything into the pkg gate > at the moment; I'm just looking for a review of this fix for when > the gate is open again). > > I'm looking for a review of the fix for bug #4316: > > http://defect.opensolaris.org/bz/show_bug.cgi?id=4316 > Need to make new version of sunstudioexpress available for 2008.11 > > Webrev is at: > > http://cr.opensolaris.org/~richb/pkg-4316-v1/ > > It also needs the fix for bug #4379 as well (thanks Danek) > http://cr.opensolaris.org/~dduvall/pkg-elfcore/pkg-clone.patch > > I tested this by putting a copy of the latest sunstudioexpress package > in a local repository with: > > #! /bin/ksh > > export ROOT=/export/home/richb/pkg/bugs/4316/gate/proto/root_i386 > export PYTHONPATH=${ROOT}/usr/lib/python2.4/vendor-packages > export REPO=http://localhost:24316/ > export > WOS_PKGS=/export/home/pkg-solaris/WOS_Packages/x/101/Solaris_11/Product/ > export > NONWOS_PKGS=/net/paradise.sfbay/export/integrate_dock/nv/nv_osol0811/i386 > > (cd src/util/distro-import ; \ > make -e BUILDID=101 Studio.import > ) > errs.cluster 2>&1 & > > > I then installed the sunstdudioexpress package on my machine with: > > $ pfexec pkg set-authority -P -O http://ipkg.sfbay.sun.com:29047 ipkg > $ pfexec pkg set-authority -O http://stard.sfbay.sun.com:24316 bug-4316 > $ pfexec pkg refresh > $ pfexec pkg install [EMAIL PROTECTED] > DOWNLOAD PKGS FILES XFER (MB) > Completed 1/1 3508/3508 174.17/174.17 > > PHASE ACTIONS > Removal Phase 1868/1868 > Install Phase 4223/4223 > Update Phase 3191/3191 > PHASE ITEMS > Reading Existing Index 9/9 > Indexing Packages 1/1 > $ pfexec pkg set-authority -P opensolaris.org > $ pfexec pkg unset-authority ipkg > $ pfexec pkg unset-authority bug-4316 > > $ pfexec pkg contents -m sunstudioexpress | grep "^depend" > depend [EMAIL PROTECTED] type=require > depend [EMAIL PROTECTED] type=require > depend [EMAIL PROTECTED] type=require > depend [EMAIL PROTECTED] type=require > depend [EMAIL PROTECTED] type=require > depend [EMAIL PROTECTED] type=require > depend [EMAIL PROTECTED] type=require > depend [EMAIL PROTECTED] type=require > depend [EMAIL PROTECTED] type=require > depend [EMAIL PROTECTED] type=require > depend [EMAIL PROTECTED] type=require > depend [EMAIL PROTECTED] type=require > depend [EMAIL PROTECTED] type=require > depend [EMAIL PROTECTED] type=require > depend [EMAIL PROTECTED] type=require > depend [EMAIL PROTECTED] type=require > depend [EMAIL PROTECTED] type=require > depend [EMAIL PROTECTED] type=require > depend [EMAIL PROTECTED] type=require > depend [EMAIL PROTECTED] type=require > > Thanks. _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
