Fujiwara - why do you want these changes added? There are plenty of other error messages in these files, following the same pattern and yet you do not change any of them. I can see the benefit of dumping out a symbol table for debugging purposes, but why here and nowhere else?
Even though these are minor changes I am reluctant to introduce any additional changes at this late stage unless we have a very good reason to do so. All changes need tested and we'd have to try and provoke these errors which is non trivial. The current webrev is fine for what we need at the minute, there are no changes required in the SUNWipkg-gui/Makefile and I'm happy to leave the N_() for now, until we can confirm post 2008.11 if we can safely remove it. So I'd prefer to stick with the posted webrev and make these additional changes post 2008.11. Webrev: http://cr.opensolaris.org/~jmr/pm_4126_v10_Nov01 JR http://docs.python.org/library/functions.html?highlight=vars#vars *vars*([object]) Without arguments, returns a dictionary corresponding to the current local symbol table. Takao Fujiwara - Tokyo S/W Center wrote: > Could you add the following patch? > > Thanks, > fujiwara > > --- pkg/src/modules/client/bootenv.py.orig 2008-11-01 22:28:18.379614385 > +0900 > +++ pkg/src/modules/client/bootenv.py 2008-11-01 22:47:56.936869885 +0900 > @@ -192,8 +192,9 @@ class BootEnv(object): > stdout = file("/dev/null"), > stderr = subprocess.STDOUT) > except OSError, e: > - emsg(_("pkg: A system error %s was caught " > - "executing %s") % (e, " ".join(cmd))) > + join_cmd = " ".join(cmd) > + emsg(_("pkg: A system error %(e)s was > caught " > + "executing %(join_cmd)s") % vars()) > > if ret != 0: > emsg(_("pkg: '%s' failed. \nwith a return > code " > @@ -229,8 +230,9 @@ Reboot when ready to switch to this upda > stdout = file("/dev/null"), \ > stderr = subprocess.STDOUT) > except OSError, e: > - emsg(_("pkg: The system error %s was caught " > - "executing %s") % (e, " ".join(cmd))) > + join_cmd = " ".join(cmd) > + emsg(_("pkg: The system error %(e)s was > caught " > + "executing %(join_cmd)s") % vars()) > > if ret != 0: > emsg(_("pkg: '%s' failed \nwith a return > code " > --- pkg/src/pull.py.orig 2008-11-01 22:49:54.167469792 +0900 > +++ pkg/src/pull.py 2008-11-01 23:01:55.689186245 +0900 > @@ -149,8 +149,9 @@ def fetch_manifest(server_url, fmri, bas > m, v = versioned_urlopen(server_url, "manifest", [0], > fmri.get_url_path()) > except: > - error(_("Unable to download manifest %s from %s") % > - (fmri.get_url_path(), server_url)) > + get_url_path = fmri.get_url_path() > + error(_("Unable to download manifest %(get_url_path)s from " > + "%(server_url)s") % vars()) > sys.exit(1) > > # join pkgname onto basedir. Manifest goes here > > _______________________________________________ > pkg-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/pkg-discuss > _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
