This looks good to me. Only thing that surprised me is that the test suite didn't catch this. Do we not test fix there?
Thanks for the quick, Brock Brad Hall wrote: > Hi, > > Link to webrev: http://cr.opensolaris.org/~bhall/bug-4450-1/ > Link to BUG: http://defect.opensolaris.org/bz/show_bug.cgi?id=4450 > > This webrev changes client.py::fix_image() to send a callback function > for "check_cancelation" instead of a boolean value, since it expects a > function. > > Longer term it would be better to either make the check_cancelation > argument optional for pieces of the code that aren't cancellation aware, > or to move the code in fix_image() into the api so that we can use > api::__check_cancelation; but both of those are more obtrusive than we > would like at this point. > > Thanks, > Brad > _______________________________________________ > pkg-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/pkg-discuss > _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
