[EMAIL PROTECTED] wrote: >> pkgsubprocess.py: >> 108-118: I think this might be simpler as: >> if not env: >> env = [ fancy list stuff ] >> >> self.pid = posix_spawnp(blah) >> > > Fixed, thanks. > > >> pspawn.c: >> Comments please? At least for what the general purpose of each function is? >> I didn't see other problems here, but that doesn't mean much. >> > > I was going to add docstrings so that the module can actually tell pydoc > about itself. Are you asking for that kind of comments, or do you want > me to annotate other parts of the code? If so, what did you find most > confusing? > I think mostly docstring type things, at least to start. I'm sure the function names were meaningful to many people, but I was lost as to the desired behavior. Certainly this was partly because I wasn't clear what a FileAction is conceptually, and so the related functions left me in the dark a bit.
Brock > Thanks, > > -j > _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
