Thanks much for your integration. I saw my patch was integrated correctly. Reading the thread, I'm not sure if you still have any problems. I hope now your problems are already fixed.
Currently, all png files are loaded from C directory with yelp so I think any symlinks are not needed. fujiwara John Rice-san wrote (11/ 8/08 03:55 AM): > Yep - as long as you have built against a clean gate and confirmed the > applied patch builds and run the CLI tests, the PM and UM tests, you are > fine to commit. > It was my screw up to build against a gate with local copies of the png > files that had not been added to the changeset in the first place, > lulling me into a false sense of confidence that all was well, until I > check out a fresh gate again to start a new workspace and couldn't build > it. You live and learn I suppose. > > JR > > Michal Pryc wrote: >> John, Takao, >> I've double checked this and it's my fault telling that the localized >> png files shold be linked. Actually everything works fine and the png >> images are taken from C locale if they are not found in the locale >> specific folder. >> >> John, >> Should I commit the changes, since they were already reviewed? >> >> Michal >> >> >> jmr wrote: >> >>> There is an issue in the SUNWpkg-gui-l10n as the makefile has been >>> modified to not copy over the localized png files, if you switch to a >>> new locale the help file references png files that do not exist. This >>> could be fixed by putting in links for the various locales to point back >>> to the png files in the C locale. >>> >>> Fujiwara what do you want to do here? >>> >>> JR >>> >>> jmr wrote: >>> >>>> I applied the patch to a clean gate and had not manually included the >>>> required png files which is why the patch broke. Adding in the png >>>> files >>>> everything builds fine. Apologies, we will respin restest and put >>>> back in. >>>> >>>> JR >>>> >>>> jmr wrote: >>>> >>>> >>>>> I've just pulled from the gate and its failing on: >>>>> The following command caused the error: >>>>> cd gui; pwd; make install >>>>> >>>>> Error: cannot open file 'help/de/package-manager.xml.in'. >>>>> >>>>> Not sure why these files are not there, as you can see from below it >>>>> looks ok. I will backout the changeset and figure out why the files >>>>> are >>>>> not appearing when I pull from the gate. >>>>> >>>>> JR >>>>> >>>>> >>>>> >>>>> [EMAIL PROTECTED] wrote: >>>>> >>>>> >>>>> >>>>>> Author: John Rice<[EMAIL PROTECTED]> >>>>>> Repository: /hg/pkg/gate >>>>>> Latest revision: 0a71653642c7a9173ed91d8173b4cd6887451c49 >>>>>> Total changesets: 1 >>>>>> Log message: >>>>>> 4464 l10n PM and UM po files need updated >>>>>> >>>>>> Files: >>>>>> create: src/gui/data/l10n.sh >>>>>> create: src/gui/help/C/en.po >>>>>> create: src/gui/help/de/de.po >>>>>> create: src/gui/help/de/legal.xml >>>>>> create: src/gui/help/de/package-manager.xml >>>>>> create: src/gui/help/de/package-manager.xml.in >>>>>> create: src/gui/help/es/es.po >>>>>> create: src/gui/help/es/legal.xml >>>>>> create: src/gui/help/es/package-manager.xml >>>>>> create: src/gui/help/es/package-manager.xml.in >>>>>> create: src/gui/help/fr/fr.po >>>>>> create: src/gui/help/fr/legal.xml >>>>>> create: src/gui/help/fr/package-manager.xml >>>>>> create: src/gui/help/fr/package-manager.xml.in >>>>>> create: src/gui/help/it/it.po >>>>>> create: src/gui/help/it/legal.xml >>>>>> create: src/gui/help/it/package-manager.xml >>>>>> create: src/gui/help/it/package-manager.xml.in >>>>>> create: src/gui/help/ja/ja.po >>>>>> create: src/gui/help/ja/legal.xml >>>>>> create: src/gui/help/ja/package-manager.xml >>>>>> create: src/gui/help/ja/package-manager.xml.in >>>>>> create: src/gui/help/ko/ko.po >>>>>> create: src/gui/help/ko/legal.xml >>>>>> create: src/gui/help/ko/package-manager.xml >>>>>> create: src/gui/help/ko/package-manager.xml.in >>>>>> create: src/gui/help/pt_BR/legal.xml >>>>>> create: src/gui/help/pt_BR/package-manager.xml >>>>>> create: src/gui/help/pt_BR/package-manager.xml.in >>>>>> create: src/gui/help/pt_BR/pt_BR.po >>>>>> create: src/gui/help/ru/legal.xml >>>>>> create: src/gui/help/ru/package-manager.xml >>>>>> create: src/gui/help/ru/package-manager.xml.in >>>>>> create: src/gui/help/ru/ru.po >>>>>> create: src/gui/help/sv/legal.xml >>>>>> create: src/gui/help/sv/package-manager.xml >>>>>> create: src/gui/help/sv/package-manager.xml.in >>>>>> create: src/gui/help/sv/sv.po >>>>>> create: src/gui/help/zh_CN/legal.xml >>>>>> create: src/gui/help/zh_CN/package-manager.xml >>>>>> create: src/gui/help/zh_CN/package-manager.xml.in >>>>>> create: src/gui/help/zh_CN/zh_CN.po >>>>>> create: src/gui/help/zh_HK/legal.xml >>>>>> create: src/gui/help/zh_HK/package-manager.xml >>>>>> create: src/gui/help/zh_HK/package-manager.xml.in >>>>>> create: src/gui/help/zh_HK/zh_HK.po >>>>>> create: src/gui/help/zh_TW/legal.xml >>>>>> create: src/gui/help/zh_TW/package-manager.xml >>>>>> create: src/gui/help/zh_TW/package-manager.xml.in >>>>>> create: src/gui/help/zh_TW/zh_TW.po >>>>>> create: src/po/pkg.pot >>>>>> update: src/gui/data/l10n.py >>>>>> update: src/pkgdefs/SUNWipkg-gui-l10n/Makefile >>>>>> update: src/po/de.po >>>>>> update: src/po/es.po >>>>>> update: src/po/fr.po >>>>>> update: src/po/it.po >>>>>> update: src/po/ja.po >>>>>> update: src/po/ko.po >>>>>> update: src/po/pt_BR.po >>>>>> update: src/po/ru.po >>>>>> update: src/po/sv.po >>>>>> update: src/po/zh_CN.po >>>>>> update: src/po/zh_HK.po >>>>>> update: src/po/zh_TW.po >>>>>> _______________________________________________ >>>>>> pkg-discuss mailing list >>>>>> [email protected] >>>>>> http://mail.opensolaris.org/mailman/listinfo/pkg-discuss >>>>>> >>>>>> >>>>>> >>>>>> >>>>> _______________________________________________ >>>>> pkg-discuss mailing list >>>>> [email protected] >>>>> http://mail.opensolaris.org/mailman/listinfo/pkg-discuss >>>>> >>>>> >>>>> >>>> _______________________________________________ >>>> pkg-discuss mailing list >>>> [email protected] >>>> http://mail.opensolaris.org/mailman/listinfo/pkg-discuss >>>> >>>> >>> _______________________________________________ >>> pkg-discuss mailing list >>> [email protected] >>> http://mail.opensolaris.org/mailman/listinfo/pkg-discuss >>> >> >> _______________________________________________ >> pkg-discuss mailing list >> [email protected] >> http://mail.opensolaris.org/mailman/listinfo/pkg-discuss >> > > _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
