No, there's no dirfd macro for Solaris. Since we're so close to cutting a release, I'm going to implement just the Solaris portion of the posix_spawn wrapper. If Linux/MacOS run into fork problems, we can look at an approach for all three platforms. Given that this is turning out to be more involved than anticipated, I'd say we should defer further work until there's a need for this feature on other platforms.
-j On Sat, Nov 08, 2008 at 12:37:56PM -0600, Tom Mueller wrote: > This change gets a compilation failure on Linux: > > modules/pspawn.c: In function 'closechild_fds': > modules/pspawn.c:453: error: dereferencing pointer to incomplete type > > If I change the dirp->dd_fd to dirfd(dirp), then it compiles ok and it runs > ok to. To test it, I removed the index directory from a repository and > started pkg.depotd. Also ran the unit test cases (the usual failures were > there but the depot seemed to run fine). > > Does the dirfd macro exist on Solaris? > > I can try a Mac on Monday when I'm back in my office. > Tom > > > [EMAIL PROTECTED] wrote: >> Since nobody has had a chance to review the webrev below, I also threw >> together a version that doesn't use fdwalk, but instead uses readdir() >> to look through /proc/self/fd, much like fdwalk does. In order for us >> to actually integrate this version, it needs to be tested on Linux and >> MacOS. I don't have the required gear, so I'll need someone to try the >> patch to see if it works. >> >> The webrev for the alternative implementation is here: >> >> http://cr.opensolaris.org/~johansen/webrev-4612-multiplat/ >> >> Thanks, >> >> -j >> >> On Fri, Nov 07, 2008 at 05:12:57PM -0800, [EMAIL PROTECTED] wrote: >> >>> Thanks to everyone who has reviewed this. I've posted a new webrev that >>> includes all of the recent changes. >>> >>> http://cr.opensolaris.org/~johansen/webrev-4612-2/ >>> >>> Thanks, >>> >>> -j >>> >> _______________________________________________ >> pkg-discuss mailing list >> [email protected] >> http://mail.opensolaris.org/mailman/listinfo/pkg-discuss >> > > begin:vcard > fn:Tom Mueller > n:Mueller;Tom > org:Sun Microsystems, Inc.;SWI Install/Update Software > adr:;;21915 Hillandale Dr;Elkhorn;NE;68022;USA > email;internet:[EMAIL PROTECTED] > title:Senior Staff Engineer > tel;work:877-250-4011 > tel;fax:877-250-4011 > tel;home:402-916-9943 > x-mozilla-html:TRUE > version:2.1 > end:vcard > > _______________________________________________ > pkg-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/pkg-discuss _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
