Danek Duvall wrote: > On Wed, Nov 12, 2008 at 07:14:05PM -0800, jmr wrote: > >> Michal Pryc wrote: >>> jmr wrote: >>>> Michal, >>>> >>>> I do not like the way you are catching the Runtime exceptions and >>>> parsing the error string to take specific actions. You need to work with >>>> Brock to get the appropriate Exceptions raised for permission denied and >>>> no defined authorities. This might be a problem getting it sorted for >>>> RC1.5 but it would be a lot more robust. >>> Hi John, >>> This is not nice IMHO either, but the fix is very important. >>> Most people will be switching to osol-re.sfbay while testing RC1.5, which >>> means there is high risk the system will be broken. >> Ok given where we are and the risk the bug poses if its not fixed I'm happy >> with this proposal - Danek and Broc what's your take on it? > > Why should I bother answering any questions if Michal's just going to put > back without a response? Danek, My fault, I should have wait for that, but I really wanted to have that fix for RC1.5 so I did putbck as I thought RC1.5 is about to be created (1pm).
> Anyway, I was going to say that the idea behind this is fine for the > moment, but the way you're testing the contents of the RuntimeError isn't > the best. Now that it's in, though, it's in, and you should concentrate on > a better way for RC2. I will be spinnign webrev to fix that. I know that it's not ideal but this was the only option I could get without touching too much code. > Perhaps we need a way to change the name of an authority, though I'd > actually suggest that you disable that ability entirely for now. The GUI > can have the same limitation here that the CLI does -- you have to add a > new authority manually with the same origin as the existing one, but a new > prefix, and delete the old one afterwards. Right, I will spin webrev, when we are disabling editing the name field. > People should be encouraged to change just the origin of their > opensolaris.org authority, not change the prefix. That should probably be > in the release notes. Will do that for RC1. best Michal _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
