Danek Duvall wrote:
> On Wed, Nov 12, 2008 at 02:22:43PM -0800, Brock Pytlik wrote:
>
>   
>> Please take a look at the webrev for 2393. I believe that will change the 
>> exception from the RuntimeError to a api_errors.PermissionsException. If 
>> there are other places you're parsing error strings, let me know quickly 
>> please as the exception flow is being changed significantly in webrevs that 
>> are going back today and tomorrow (and have been out for a week or so). 
>> Also, given that last I checked, the packagemanager could only be run with 
>> pfexec, I'm confused as to how a permissions issue could ever happen given 
>> that.
>>     
>
> It isn't a permissions issue.  The way they're renaming an authority is by
> deleting the authority, then adding it again with a different name.
> Problem is, Image.gen_authorities() raises a RuntimeError if there are no
> authorities in the ImageConfig object.
>   
My fault, I misunderstood what was going on.
> The most straightforward way out of this is for the GUI to disallow the
> operation in the first place.  We might also have prevent ImageConfig from
> deleting its last authority, but that would require another exception to be
> raised and caught.
>
> I think any work we might do in the core code is likely to take more design
> time than we have for November.
>   
I agree.
Brock
> Danek
>   

_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to