Line 59-60, 69-70: I'd rather see us not use this construction to assign values. If I hadn't heard Danek mentioning this in the hall the other day, I'd assume that user was set to a boolean value. IMO, it's a time where being more verbose would make the code more accessible and maintainable, but maybe I'm the only one.
Could get_username be written in terms of get_userid? Maybe not since get_userid id seems to sometimes return a username and sometimes return a userid, but it'd be nice if we could commonize some of this code. Other than that, LGTM. Brock Shawn Walker wrote: > Greetings, > > The following webrev contains fixes for the following issues: > > 4446 pkg operations break on 9+ character usernames > > webrev: > http://cr.opensolaris.org/~swalker/pkg-4446/ > > _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
