On Wed, Nov 12, 2008 at 06:10:24PM -0800, Brock Pytlik wrote:

> http://cr.opensolaris.org/~bpytlik/ips-4886-v1/

image.py:

  - line 180: what does this guy intended to do?

  - line 1451: wow, this is a bit dense.  There are some things in here
    that don't make complete sense to me, but I'll try to rephrase it
    anyway.

        try:
            mod_time = os.stat(cache_file).st_mtime
        except EnvironmentError, e:
            if e.errno == errno.ENOENT:
                mod_time = None
            else:
                raise

        if not self._catalog or self._cache_reread or \
          mod_time != self._catalog_cache_mod_time:
            try:
                load_pkl()
            except blah:
                raise Runtime

            # This should come after the attempt to load the pickle;
            # otherwise the modtime isn't always going to be a good test.
            self._catalog_cache_mod_time = mod_time

    I'm still not sure I understand how you're using _cache_reread.  It's
    only set to True right after you've written the cache, but there's no
    point in reading it back in at that point, since what's on disk matches
    what's in memory -- unless the modtime has changed.  Am I confused?

Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to