Brock Pytlik wrote:
> Line 59-60, 69-70: I'd rather see us not use this construction to assign
> values. If I hadn't heard Danek mentioning this in the hall the other
> day, I'd assume that user was set to a boolean value. IMO, it's a time
> where being more verbose would make the code more accessible and
> maintainable, but maybe I'm the only one.
I personally disagree; if only because every construct in Python was
just as strange to me until I learned it :-)
> Could get_username be written in terms of get_userid?
Yes, actually, I hadn't noticed that:
return pwd.getpwuid(get_userid())[0]
Nice spot.
> Maybe not since
> get_userid id seems to sometimes return a username and sometimes return
> a userid, but it'd be nice if we could commonize some of this code.
No, it always returns a userid, carefully note the call to
get_*user*_by_*name* :-)
Thanks for the review.
Cheers,
--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
