Brock Pytlik wrote: > jmr wrote: >> Michal Pryc wrote: >> >>> jmr wrote: >>> >>>> Michal, >>>> >>>> I do not like the way you are catching the Runtime exceptions and >>>> parsing the error string to take specific actions. You need to work with >>>> Brock to get the appropriate Exceptions raised for permission denied and >>>> no defined authorities. This might be a problem getting it sorted for >>>> RC1.5 but it would be a lot more robust. >>>> >>> Hi John, >>> This is not nice IMHO either, but the fix is very important. >>> Most people will be switching to osol-re.sfbay while testing RC1.5, >>> which means there is high risk the system will be broken. >>> >> Ok given where we are and the risk the bug poses if its not fixed I'm >> happy with this proposal - Danek and Broc what's your take on it? This >> will need to land in the next few hours if its to make RC 1.5. >> >> As long as a follow up fix goes in before RC2 for the exceptions we >> should be ok. >> >> JR >> > Please take a look at the webrev for 2393. I believe that will change > the exception from the RuntimeError to a > api_errors.PermissionsException. If there are other places you're > parsing error strings, let me know quickly please as the exception flow > is being changed significantly in webrevs that are going back today and > tomorrow (and have been out for a week or so). Also, given that last I > checked, the packagemanager could only be run with pfexec, I'm confused > as to how a permissions issue could ever happen given that. > > Brock
Brock, Somehow I missed this e-mail. I did putback to reflect changes from RuntimeError to a api_errors.PermissionsException as a part of: http://cr.opensolaris.org/~migi/13_10_2008_bugs_4987_4990_v1/ (226,372,391,470,498 - repository.py), (1441 - packagemanager.py) There is still one RuntimeError 379,403 - repository.py which is "no definied authorities" This one should now never happen in the packagemanager as we are not allowing user to remove repository if there is only one and we do not allow to change the name of the repository, so I think we can skip changing this for 2008.11. best Michal Pryc _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
