Thanks Michal, line spacing will wait post 2008.11, > This webrev looks fine, except the above issue, which will need to > stay at the moment. > > Just one thing, line 1214: > (uex.args[0] == errno.EDQUOT or > > shouldn't be: > > (uex.args[0] == errno.EDQUOT or \ > > ?? Nope within brackets the \ is not required.
JR > > best > Michal > > jmr wrote: >> Michal - just uncovered another potential stopper. >> >> If you don't have a network connection and you try to do an Update All >> from UM you will dump a stack trace and progress will continue until you >> kill UM. Fix is simple one liner, checking for existence of uex.args >> before attempting to access them. >> >> Bug: 5172: UM throws stack trace when no network is present during >> Update All >> http://defect.opensolaris.org/bz/show_bug.cgi?id=5172 >> >> Webrev: http://cr.opensolaris.org/~jmr/um_5172_v1_Nov18/ >> >> JR >> _______________________________________________ >> pkg-discuss mailing list >> [email protected] >> http://mail.opensolaris.org/mailman/listinfo/pkg-discuss > _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
