Shawn Walker wrote: > Danek Duvall wrote: >> On Mon, Nov 17, 2008 at 07:22:10PM -0600, Shawn Walker wrote: >> >>> http://cr.opensolaris.org/~swalker/pkg-3540-5153/ >> client.py: >> >> - line 1987: This makes it sound like there's just no history, as opposed >> to there being no history directory. The messaging should be changed >> regardless, but perhaps it should try to correct the problem before >> erroring out? > > Since "pkg history" is a read-only command, I didn't want to make any > changes to the image and thus I didn't see any point in trying to > correct the lack of a directory. > > The next time an operation occurs that records history, it will > automatically re-create the directory. > > I purposefully intended to equate "no history directory" with "no > history" with the exception that the return code is 1 to indicate that > there was a failure. > > I could just change this to print the headers for the listing instead > and just not list anything.
Okay, I decided to just change this so the history command prints nothing. Updated webrev: http://cr.opensolaris.org/~swalker/pkg-3540-5153-2/ Thanks, -- Shawn Walker _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
