On Tue, Nov 18, 2008 at 10:51:42AM +0000, Michal Pryc wrote:
> It's this what you were suggesting?
> http://cr.opensolaris.org/~migi/18_10_2008_bug_5172_v2/
Yes, that's it. Except please get rid of the parentheses around the
exception names. That's only necessary if you have more than one. And
please get rid of the backslashes inside parens where you're adding or
changing code.
I don't follow your statement about how it's similar to something in
image.py -- there's nothing there that looks for either EDQUOT or ENOSPC.
Can you be more specific?
My remaining concern is that you're catching all exceptions on line 1224,
which is usually a mistake. We've concentrated our catching of Exception
to the top level, as lower down it's usually too large an umbrella. Can
you explain why you do it this way here?
A couple of other nits:
- line 1226: _() encompasses what_msg, as well as the hard-coded string.
Is that intentional? It means that for every possible "what_msg",
there has to be a translation of "<what_msg> unexpected error:", which
doesn't seem right.
- line 1226: no need for parens around what_msg
Thanks,
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
