Brock Pytlik wrote: > Webrev: > http://cr.opensolaris.org/~bpytlik/ips-5206-v1/ > > Bug: > http://defect.opensolaris.org/bz/show_bug.cgi?id=5206 > > This addresses some of the memory use issues with the depot. The bug > report contains the analysis, but in short, this begins to address the > issue, but doesn't sole it entirely.
catalog.py: line 288: I'm assuming this is a function to signal that a query is *finished* as opposed to check if it is. Can you add a docstring? I almost expected a bool return value. query_engine.py: line 149, 150: I think you can get rid of these and then change line 157: s/fmri_list/sorted(fmri_set)/ ? repository.py: I don't think the client actually looks for a Content-Length header right now for search results, and has no way to tell if it actually got all the results. Also, it looks as though the results could easily be streamed here using response.stream. However, I wouldn't make any changes for those things right now, just file bugs and move on. Cheers, -- Shawn Walker _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
